Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lerna/monorepo switch or alternate cookiecutter #292

Open
bollwyvl opened this issue Mar 22, 2023 · 1 comment
Open

Add a lerna/monorepo switch or alternate cookiecutter #292

bollwyvl opened this issue Mar 22, 2023 · 1 comment

Comments

@bollwyvl
Copy link
Contributor

bollwyvl commented Mar 22, 2023

Problem

It doesn't take long for an extension to benefit from multiple, separately npm-packaged extensions which are still distributed in the same pypi package. This is particularly relevant to themes.

Proposed Solution

One of:

  • add a use_lerna switch to this repo
  • split out an extension-cookiecutter-ts-lerna, as it's a whole other thing

Additional context

This stemmed from a discussion on theme extensions, which don't play well outside of strict light/dark variants, but the monorepo pattern

  • adds lerna to package.json
  • uses the packages/ directory layout
  • update pyproject.toml to ensure the static assets are happy
  • uses a composite build
@welcome
Copy link

welcome bot commented Mar 22, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant