Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list view: icons too large #37

Open
nick-youngblut opened this issue Sep 20, 2022 · 3 comments
Open

list view: icons too large #37

nick-youngblut opened this issue Sep 20, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@nick-youngblut
Copy link

When I click on list view, many of the icons on the start of each list entry are too large:

Screen Shot 2022-09-19 at 5 13 18 PM

JupyterLab Version 3.4.7

MacOS v12.5.1, MacBook Pro (13-inch, M1, 2020)

@nick-youngblut nick-youngblut added the bug Something isn't working label Sep 20, 2022
@fcollonval
Copy link
Member

Thanks for reporting @nick-youngblut

Would you be willing to open a PR to fix that? I can provide pointers.

@nick-youngblut
Copy link
Author

Sure, but I'd need a lot of pointers. I don't even now where to begin

@fcollonval
Copy link
Member

The good way is

  1. to open the development tools in your browser
  2. to select the element, you want to edit
  3. to add new CSS rule

See example in the below screencast - it demonstrate how to set the background-color of an icon.

test-style

You may need to search the web for your specific trouble as I cannot reproduce it (on Firefox on Windows).

Once you know what CSS rule needs to be set. You can open a PR modifying https://github.com/jupyterlab-contrib/jlab-enhanced-launcher/blob/master/style/table.css to add that new rule.

Don't hesitate to open the PR early even if it does not work so I can provide help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants