New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objToMesh should use the buildShape helper #605

Open

martinRenou opened this issue Nov 28, 2024 · 0 comments

Milestone

Member

martinRenou commented Nov 28, 2024

The function objToMesh: https://github.com/jupytercad/JupyterCAD/blob/main/packages/base/src/3dview/mainview.tsx#L923

is not correctly implemented. It should use the buildShape helper function.
The downside of not using buildShape is:

wrong coloring
no bounding box for selection
no support for clip plane
etc

The text was updated successfully, but these errors were encountered:

martinRenou added bug and removed bug labels

martinRenou added this to the 3.1.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment