Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurating the viewport #573

Open
trungleduc opened this issue Nov 7, 2024 · 5 comments
Open

Allow configurating the viewport #573

trungleduc opened this issue Nov 7, 2024 · 5 comments
Milestone

Comments

@trungleduc
Copy link
Member

trungleduc commented Nov 7, 2024

Always displaying the transform control makes it easy to accidentally move the objects while rotating the camera. Other CAD software do not activate the transform control by default. I think we should follow this behavior.

Since we had already the dialog to show and hide the axes helper, we can change this dialog to a viewport config dialog with the following items:

  • Toggle axes helper
  • Toggle object highlight mode: using a bounding box or using highlight color
  • Highlight or bounding box color selector
  • Viewport background color, it would be great if we could support gradient color.

We could reuse the setting system of JupyterLab to persist the viewport config.

@martinRenou
Copy link
Member

Agreed! A simple toggle button like the wireframe may be enough

@arjxn-py
Copy link
Member

arjxn-py commented Nov 7, 2024

Makes Sense! Will be happy to do it :)

@trungleduc trungleduc changed the title Allow toggling the transform control Allow configurating the viewport Nov 9, 2024
@trungleduc
Copy link
Member Author

I updated the issue about the viewport config. The transform control merits its own toggle button on the toolbar

@martinRenou
Copy link
Member

  • Toggle object highlight mode: using a bounding box or using highlight color
  • Highlight or bounding box color selector
  • Viewport background color, it would be great if we could support gradient color

I'm thinking these should be using normal JupyterLab settings.

There may be a way to add a shortcut in the toolbar to go to the settings page for JupyterCAD?

  • Toggle axes helper

I feel like this one should instead be stored on a per-file basis in StateDB like the other view states listed in #601

@trungleduc
Copy link
Member Author

I'm thinking these should be using normal JupyterLab settings.

There may be a way to add a shortcut in the toolbar to go to the settings page for JupyterCAD?

If we put it into JupyterLab settings, having the shortcut is a must. I know lots of users do not know about the setting page of JupyterLab.

I feel like this one should instead be stored on a per-file basis in StateDB like the other view states listed in #601

just checked FreeCAD, it's at application level. I would follow them for these configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants