Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates/login.html: fix 404s in offsite How to set a password docs, link to TLS/SSL if scheme!=https #288

Open
1 of 4 tasks
westurner opened this issue Jul 9, 2024 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@westurner
Copy link
Contributor

westurner commented Jul 9, 2024

Description

Reproduce

  1. Cause a login failure e.g. by opening http://localhost:8888/?token=invalidtoken
  2. 404: Click the " enable a password. " or " the documentation on how to enable a password " links

Expected behavior

  • the link to the offsite, online docs on how to set a password should not 404

Context

  • Operating System and version:
  • Browser and version:
  • Jupyter NbClassic version:
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter nbclassic` here, use `--debug` if possible.
Browser Output
Paste the output from your browser Javascript console here, if applicable.
@westurner westurner added bug Something isn't working status:Needs Triage labels Jul 9, 2024
@RRosio RRosio added documentation Improvements or additions to documentation and removed status:Needs Triage labels Jul 16, 2024
@RRosio
Copy link
Collaborator

RRosio commented Jul 16, 2024

Thank you for opening this issue! Feel welcome to submit any PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants