Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] alternate preview layout maintains separate hidden state #4100

Open
5 of 10 tasks
ibhagwan opened this issue Nov 18, 2024 · 0 comments
Open
5 of 10 tasks

[Bug] alternate preview layout maintains separate hidden state #4100

ibhagwan opened this issue Nov 18, 2024 · 0 comments

Comments

@ibhagwan
Copy link

Checklist

  • I have read through the manual page (man fzf)
  • I have searched through the existing issues
  • For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version

0.56.2

OS

  • Linux
  • macOS
  • Windows
  • Etc.

Shell

  • bash
  • zsh
  • fish

Problem / Steps to reproduce

Consider the below command:

echo "line1\nline2" | fzf --preview 'echo $FZF_PREVIEW_COLUMNS' --preview-window 'right,60%,<80(down:45%)' --preview-window 'nohidden'

Run the command in any terminal width and use a keybind to hide the preview:

  • If the preview was down extend the terminal width until preview is shown on the right
  • If the preview was right decrease the terminal width until preview is shown at the bottom

It's very easy to do if you have a tmux split into two panes and then use <tmux-prefix>-z to "zoom" the pane which extends it to full terminal width.

It seems that the hidden state is saved per layout (horizontal/veritcal), when extending the terminal width the preview will lose its hidden state and will be un-hidden, when decreasing the terminal width again the preview will be hidden again.
@ibhagwan ibhagwan mentioned this issue Nov 18, 2024
Closed
6 tasks
ibhagwan added a commit to ibhagwan/fzf-lua that referenced this issue Nov 18, 2024
@ibhagwan
refactor: native fzf flex layout (closes
7c2d35b 
Use alternative preview layout instead of using a "transform",
simpler, and we don't need to take into account the hidden state of
the preview as well as decrease the minimum fzf version for native
fzf flex layout to 0.31 (instead of 0.46).

Has known issue upstream where if the layout changes upon resize
the hidden state of the preview is lost:
junegunn/fzf#4100

Closes #1527
ibhagwan added a commit to ibhagwan/fzf-lua that referenced this issue Nov 18, 2024
@ibhagwan
refactor: native fzf flex layout (closes
11430b9 
Use alternative preview layout instead of using a "transform",
simpler, and we don't need to take into account the hidden state of
the preview as well as decrease the minimum fzf version for native
fzf flex layout to 0.31 (instead of 0.46).

Has known issue upstream where if the layout changes upon resize
the hidden state of the preview is lost:
junegunn/fzf#4100

Closes #1527
ibhagwan added a commit to ibhagwan/fzf-lua that referenced this issue Nov 18, 2024
@ibhagwan
refactor(win): native fzf flex layout
944f8b3 
Use alternative preview layout instead of using a "transform",
simpler, and we don't need to take into account the hidden state of
the preview as well as decrease the minimum fzf version for native
fzf flex layout to 0.31 (instead of 0.46).

Has known issue upstream where if the layout changes upon resize
the hidden state of the preview is lost:
junegunn/fzf#4100

Closes #1527
ibhagwan added a commit to ibhagwan/fzf-lua that referenced this issue Nov 18, 2024
@ibhagwan
refactor(win): native fzf flex layout
26fa89f 
Use alternative preview layout instead of using a "transform",
simpler, and we don't need to take into account the hidden state of
the preview as well as decrease the minimum fzf version for native
fzf flex layout to 0.31 (instead of 0.46).

Has known issue upstream where if the layout changes upon resize
the hidden state of the preview is lost:
junegunn/fzf#4100

Closes #1527
ibhagwan added a commit to ibhagwan/fzf-lua that referenced this issue Nov 18, 2024
@ibhagwan
refactor(win): native fzf flex layout
1ec239a 
Use alternative preview layout instead of using a "transform",
simpler, and we don't need to take into account the hidden state of
the preview as well as decrease the minimum fzf version for native
fzf flex layout to 0.31 (instead of 0.46).

Has known issue upstream where if the layout changes upon resize
the hidden state of the preview is lost:
junegunn/fzf#4100

Closes #1527
ibhagwan added a commit to ibhagwan/fzf-lua that referenced this issue Nov 19, 2024
@ibhagwan
refactor(win): native fzf flex layout
8c59894 
Use alternative preview layout instead of using a "transform",
simpler, and we don't need to take into account the hidden state of
the preview as well as decrease the minimum fzf version for native
fzf flex layout to 0.31 (instead of 0.46).

Has known issue upstream where if the layout changes upon resize
the hidden state of the preview is lost:
junegunn/fzf#4100

Closes #1527
ibhagwan added a commit to ibhagwan/fzf-lua that referenced this issue Nov 19, 2024
@ibhagwan
refactor(win): native fzf flex layout
0c00a55 
Use alternative preview layout instead of using a "transform",
simpler, and we don't need to take into account the hidden state of
the preview as well as decrease the minimum fzf version for native
fzf flex layout to 0.31 (instead of 0.46).

Has known issue upstream where if the layout changes upon resize
the hidden state of the preview is lost:
junegunn/fzf#4100

Closes #1527
@ibhagwan ibhagwan mentioned this issue Nov 19, 2024
Merged
ibhagwan added a commit to ibhagwan/fzf-lua that referenced this issue Nov 19, 2024
@ibhagwan
refactor(win): native fzf flex layout
48f8a85 
Use alternative preview layout instead of using a "transform",
simpler, and we don't need to take into account the hidden state of
the preview as well as decrease the minimum fzf version for native
fzf flex layout to 0.31 (instead of 0.46).

Has known issue upstream where if the layout changes upon resize
the hidden state of the preview is lost:
junegunn/fzf#4100

Closes #1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ibhagwan