Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Compilation Performance: nospecialize on function params #19

Open
ghost opened this issue Jun 4, 2020 · 0 comments
Open
Labels
performance CPU, RAM, disk utilization and efficiency question Further information is requested

Comments

@ghost
Copy link

ghost commented Jun 4, 2020

We should be able to use @nospecialize on the arguments to Salsa derived functions and input functions, because the code should be entirely unchanged no matter what the type of the argument is: look it up then get it out of the dictionary.

But when we tried adding it, we either didn't see any affect at all, or sometimes it even got slower, maybe?

We should do a thorough investigation here and settle on the right answer.

For example:
https://github.com/RelationalAI-oss/Salsa.jl/blob/705f61017439290bc811e496f0abf1978ac66799/src/default_storage.jl#L140-L146

https://github.com/RelationalAI-oss/Salsa.jl/blob/705f61017439290bc811e496f0abf1978ac66799/src/default_storage.jl#L302-L309

This one doesn't have a TODO, but i also don't really know if it's doing anything:
https://github.com/RelationalAI-oss/Salsa.jl/blob/705f61017439290bc811e496f0abf1978ac66799/src/Salsa.jl#L608-L609

@ghost ghost added performance CPU, RAM, disk utilization and efficiency question Further information is requested labels Jun 4, 2020
@NHDaly NHDaly assigned NHDaly and unassigned NHDaly Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance CPU, RAM, disk utilization and efficiency question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant