default_juliaformatter_config not same as JuliaFormatter default?

[xgdgsc]

LanguageServer.jl/src/requests/features.jl

Line 143 in 48ea5bf

function default_juliaformatter_config(params)

from my understanding it is different than JuliaFormatter.jl default . Is it the reason I have to create a .JuliaFormatter.toml file for every project? Especially the margin setting.

[davidanthoff]

Yes, the defaults are different. In general the defaults in VS Code are meant to be very minimal, i.e. a lot less opiniated than the current defaults for JuliaFormatter. We at some point had a plan how to unify this, but we somehow got stuck in the middle... Probably worth revisiting this, as it is pretty annoying...

[xgdgsc]

Other options might not make a huge difference in view. Would you mind me changing margin to 92 before a unified solution is available ?

I' m surprised when I heard some one use https://marketplace.visualstudio.com/items?itemName=0h7z.vscode-julia-format&ssr=false#overview for formatting.

[davidanthoff]

Would you mind me changing margin to 92 before a unified solution is available?

I think we actually agreed that JuliaFormatter would change its default to be less opinionated. One key thing is that by default we don't want any line breaks added or removed, so I don't think we should change the VS Code default right now, just to change it back again once we unify.