Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High-level stable API #56

Open
KristofferC opened this issue Oct 26, 2017 · 4 comments
Open

High-level stable API #56

KristofferC opened this issue Oct 26, 2017 · 4 comments
Assignees

Comments

@KristofferC
Copy link
Contributor

I'm in the progress of upgrading FemtoCleaner (the GitHub bot that fixes deprecations) from CSTParser 0.2.1 to the current version of CSTParser.
However, progress is very slow because since CSTParser does not have an API, a lot of the code in FemtoCleaner depends on the internals of CSTParser, which are now completely changed.

If the idea is to use CSTParser to build nice tools, I feel there needs to be a more high-level API where some stability is expected.

@ZacLN
Copy link
Contributor

ZacLN commented Oct 26, 2017

Yep I think things are fairly settled down now in terms of the backend. What sort access functions are you after?

@KristofferC
Copy link
Contributor Author

Some sort of API where I don't have to access any internals. For an If expression, getters like condition and body might make sense.

Basically, if you change the internals to be completely heterogeneous (no more .args field), the API would stay the same.

@ZacLN
Copy link
Contributor

ZacLN commented Nov 1, 2017

Alright will do, I'll draw up a doc outlining proposed getters in the style of the current _get_fname and stick it in a wiki

@Keno
Copy link
Collaborator

Keno commented Nov 2, 2017

It'd also be good to think about the overlay tree stuff we'd discussed (created on demand with stored parents and absolute locations) and probably put it in this package. Deprecations.jl has an ad hoc version of it, but it's probably not the right approach.

@ZacLN ZacLN self-assigned this Nov 3, 2017
@davidanthoff davidanthoff added this to the Backlog milestone Jun 12, 2019
@davidanthoff davidanthoff removed this from the Backlog milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants