Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative patch method #15

Open
adoxa opened this issue Dec 10, 2018 · 2 comments
Open

Alternative patch method #15

adoxa opened this issue Dec 10, 2018 · 2 comments
Assignees

Comments

@adoxa
Copy link

adoxa commented Dec 10, 2018

I just got 3-D Ultra MiniGolf from My Abandonware. It seems MINIGOLF.EXE could be patched, rather than all the sounds: change the byte at 0x30819 from 0x65 to 0x3E (the download is already patched, so that's v1.1; for the technically minded it replaces gs: with ds:). I suspect other exes could be similarly patched, check for the hex sequence 65 8A 06 66 89 43 1C 46.

@juanitogan
Copy link
Owner

Curious. Thanks! I'll have to pull it apart when I have time (no idea when that might be) and see what's up. I'm suffering major deja vu over this and I have no clue as to why right now. Changing registers smells a little funny to me but I'm not the expert on what kind of compiler bugs are common either. Also, another user there has already complained about it not working on Win7. But, as I obviously know, that could be due to a number of other reasons. Another point of concern that forces a lot of testing with any fix is that I recall CyberStrom, for example, is stable with the audio on some machines and not others. I don't recall if MG was the same way, but the possibility is always there. I think I found that MG was semi-stable on some machines, but always failed eventually. But don't recall for sure (and I don't have many machines to test on anyway).

@juanitogan juanitogan self-assigned this Dec 11, 2018
@adoxa
Copy link
Author

adoxa commented Dec 11, 2018

Sorry, I should have mentioned that I was using 64-bit 7. A VM would usually crash, but start sometimes; my actual system seems to start most times, but crash sometimes. In both cases playing a hole would always seem to crash.

I have no idea why it's using gs, especially since it just initialises it to ds, anyway. It seems 64-bit Windows uses gs instead of fs, so that might be the problem, it gets reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants