Skip to content

Commit

Permalink
Batch mode no longer automatically enables verbose mode.
Browse files Browse the repository at this point in the history
  • Loading branch information
jtesta committed Dec 5, 2024
1 parent d9c703c commit e318787
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ For convenience, a web front-end on top of the command-line tool is available at
- Added warning to all key exchanges that do not include protections against quantum attacks due to the Harvest Now, Decrypt Later strategy (see https://en.wikipedia.org/wiki/Harvest_now,_decrypt_later).
- Migrated from deprecated `getopt` module to `argparse`; partial credit [oam7575](https://github.com/oam7575).
- When running against multiple hosts, now prints each target host regardless of output level.
- Batch mode (`-b`) no longer automatically enables verbose mode, due to sometimes confusing results; users can still explicitly enable verbose mode using the `-v` flag.

### v3.3.0 (2024-10-15)
- Added Python 3.13 support.
Expand Down
1 change: 0 additions & 1 deletion src/ssh_audit/ssh_audit.py
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,6 @@ def process_commandline(out: OutputBuffer, args: List[str]) -> 'AuditConf': # p

if argument.batch is True:
aconf.batch = True
aconf.verbose = True

# If one -j was given, turn on JSON output. If -jj was given, enable indentation.
aconf.json = argument.json > 0
Expand Down
2 changes: 1 addition & 1 deletion test/test_auditconf.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def test_audit_conf_process_commandline(self):
conf = c('-64 localhost')
self._test_conf(conf, host='localhost', ipv4=True, ipv6=True, ipvo=(6, 4))
conf = c('-b localhost')
self._test_conf(conf, host='localhost', batch=True, verbose=True)
self._test_conf(conf, host='localhost', batch=True)
conf = c('-n localhost')
self._test_conf(conf, host='localhost', colors=False)
conf = c('-v localhost')
Expand Down

0 comments on commit e318787

Please sign in to comment.