-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ordering of parameters makes isBetween a non-starter #1
Comments
I would expect |
One possibility would be |
@ljharb Then you still have to resolve the issue with "between" implying no bounds order and the inclusivity issue. It's not worth going that route. |
True. "is between" to me implies it's exclusive on both ends, though, and "order" would be LTR. |
Thank you for the feedback; I am ready to drop The |
Nobody is ever going to remember the order of parameters for
isBetween
. Without looking, if I had to guess at an order, it would be "lower bound", "upper bound", then the number being tested. Actually, I lied because I would expect the bounds to be given in either order ("between" works both ways in English). I don't see a way this could ever be resolved, and that's not even touching upon the inclusivity question of the bounds. I suggest you abandonisBetween
and go with the alternative suggestion of anisIncreasing
(orisNotDecreasing
) andisStrictlyIncreasing
function.The text was updated successfully, but these errors were encountered: