Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Trap focus inside modal/dialog #8

Open
jrobind opened this issue Dec 4, 2020 · 0 comments
Open

Trap focus inside modal/dialog #8

jrobind opened this issue Dec 4, 2020 · 0 comments
Labels
bug Something isn't working code level medium vanilla

Comments

@jrobind
Copy link
Owner

jrobind commented Dec 4, 2020

When the lesson view modal appears there is no focus trap which is bad for assistive tech users. Currently, there is no way for a user to tab onto the close button and screen readers will also be unaware that a modal has appeared on screen.

Screen Shot 2020-12-03 at 23 09 18

I suggest we follow the W3 spec: https://www.w3.org/TR/wai-aria-practices-1.1/examples/dialog-modal/dialog
@jrobind jrobind added bug Something isn't working code level medium labels Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working code level medium vanilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrobind