deft--org-complete is generating broken links

[gabrielhidasy]

The current implementation for deft--org-complete selects 'file' from (deft-find-all-files-no-prefix) and concats "deft:" and with (substring file 1)`, but file is already the file name, so it is removing the first character and making an invalid link.

(defun deft--org-complete ()
  (let ((file (completing-read "file" (deft-find-all-files-no-prefix))))
    (concat "deft:" (substring file 1))))

This can be fixed by removing (substring file 1), and for a bit more clarity replacing "file" with "file: " looks a bit better

(defun deft--org-complete ()
  (let ((file (completing-read "file: " (deft-find-all-files-no-prefix))))
    (concat "deft:" file)))

[gabrielhidasy]

Btw, my deft--org-complete is a bit different, I wanted to display note titles instead of filenames, but that's more of a preference

(defun deft--file-title-and-name (f)
  (let ((title (deft-file-title f))
	(fn (replace-regexp-in-string
	     (expand-file-name deft-directory) "" f)))
    (list title fn)))

(defun deft--org-complete ()
  (let ((file (car
	       (let ((choices
		      (mapcar 'deft--file-title-and-name
			      (deft-find-all-files))))
  (alist-get
   (completing-read "file: " choices)
   choices nil nil 'equal)))))
    (concat "deft:" file)))