About the rotation of q2 logs

[cyp19901124]

Regarding the rotation of q2 logs, I have configured the following content in the 00_logger.xml file to test the rotation and deletion of q2 logs, but the functionality to delete expired files is not working.

<log-listener class="org.jpos.util.DailyLogListener">
    <property name="window" value="86400" />
    <property name="prefix" value="logs/q2/" />
    <property name="suffix" value="q2.log"/>
    <property name="date-format" value="yyyy-MM-dd-HH"/>
    <property name="compression-format" value="gzip"/>
    <property name="maxsize" value="10000000"/>
    <property name="maxage" value="86400"/>
</log-listener>

I have checked and debugged the source code and found that the issue lies in the DEF_MAXDEPTH parameter. The parameter determines the depth of file queries and has a default value of 1. As a result, it cannot find expired files under the "logs/q2" directory. I suggest making this parameter configurable in the 00_logger.xml file.

try {
    Files.find(logBasePath, DEF_MAXDEPTH,
            (path, attributes) ->
                    path.getFileName().toString().matches(deleteRegex)
                    && attributes.isRegularFile()
                    && currentSystemTime - attributes.lastModifiedTime().toMillis() >= maxAge)
            .forEach(path -> {
                try {
                    Files.delete(path);
                } catch (IOException e) {
                    e.printStackTrace(System.err);
                }
            });
} catch (IOException e) {
    e.printStackTrace(System.err);
}

[ar]

Thank you for the report.

Can you confirm if your problem goes away if you use the following config?

<property name="prefix" value="log/q2"/>
<property name="suffix" value=".log"/>

without your trailing / in the prefix?

Deleting files is a dangerous operation. Setting DEF_MAXDEPTH to 1 as the default limit for recursive deletion operations provides a safer approach, but I agree with you that this should be configurable for situations where you know what you're doing.

[cyp19901124]

Thank you very much for your quick response and for addressing the issue. I’ve confirmed that the functionality has indeed been fixed with your updates. I apologize for the delay in my reply; due to my infrequent use of GitHub, I only recently noticed the fix, and a few months have passed.

Again, I appreciate your support and for making the DEF_MAXDEPTH parameter configurable, which greatly helps in scenarios where more control is needed.

[alcarraz]

Actually, the PR was never merged, what probably worked for you, if you tried, was removing the trailing slash. @ar, perhaps we can do that automatically to avoid further confusion. ---- Enviado desde mi móvil, disculpas por la brevedad. Sent from my cellphone, I apologize for the brevity. Andrés Alcarraz. El jue, 5 set. 2024, 20:21, Thomas chen ***@***.***> escribió:

…

Thank you very much for your quick response and for addressing the issue. I’ve confirmed that the functionality has indeed been fixed with your updates. I apologize for the delay in my reply; due to my infrequent use of GitHub, I only recently noticed the fix, and a few months have passed. Again, I appreciate your support and for making the DEF_MAXDEPTH parameter configurable, which greatly helps in scenarios where more control is needed. — Reply to this email directly, view it on GitHub <#580 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA42ROYKL45TDP2DHJYH4LLZVD7SZAVCNFSM6AAAAABNXS6TJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSHE4TOMZUHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ar]

We certainly can.