Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally shutdown Q2 on configuration error #191

Closed
ar opened this issue Dec 5, 2018 · 3 comments
Closed

Optionally shutdown Q2 on configuration error #191

ar opened this issue Dec 5, 2018 · 3 comments

Comments

@ar
Copy link
Member

ar commented Dec 5, 2018

When there's a configuration error, Q2 renames the QBean descriptor to .BAD or .DUP and raises a ConfigurationException. In some scenarios, it is desirable to actually exit Q2 (so that the problem can be eagerly detected).

This should be an option (either configuration property or Q2 start-up flag.

@alcarraz
Copy link
Contributor

What if, while we work on a more sophisticated solution, we just add a strategy for handling the different exceptions/errors?

One could plug a strategy and the default one would do what it currently does. So we give total freedom to developers.

We can later implement other behaviors, or even as a strategy, a fail-on-errors (or the like) flag could activate a specific strategy, if we want to implement it. But then someone could choose to implement a strategy that only quits on errors, or only on dups, or even on a condition of the filename.

This comment was fired by a discussion on slack, link valid for 90 days.

@alcarraz
Copy link
Contributor

Also, this issue is quite related to #553

@ar
Copy link
Member Author

ar commented Nov 22, 2023

What if, while we work on a more sophisticated solution, we just add a strategy for handling the different exceptions/errors?

I don't think we want to have a thousand ways to achieve a simple thing such as aborting on failing QBeans. The --exit-on-failed-deploy=startup|always is all we need. I'll close this issue and we can continue in #553.

@ar ar closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants