You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At least two participants that parse a Card. SelectDestination and CheckFields and maybe we can let SelectDestination to reuse the one from CheckFields if present in the context.
I was planning to make an issue and PR for this if you think that would be interesting. SelectDestination would have a property like use-card (or a much better name that I'm sure someone would come up with) that, if not null, will check if already present in the context, so we don't have to parse it twice.
I wonder if we want that to be ContexConstants.CARD by default, or null for a stricter backward compatibility. I'm leaning toward the former, if there is an object in the context, with key CARD, and it is an instance of Card it most probably (>99%) is the transaction's card.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Bringing the discussion from slack so it doesn't get lost.
At least two participants that parse a
Card
.SelectDestination
andCheckFields
and maybe we can letSelectDestination
to reuse the one fromCheckFields
if present in the context.I was planning to make an issue and PR for this if you think that would be interesting.
SelectDestination
would have a property like use-card (or a much better name that I'm sure someone would come up with) that, if not null, will check if already present in the context, so we don't have to parse it twice.I wonder if we want that to be
ContexConstants.CARD
by default, ornull
for a stricter backward compatibility. I'm leaning toward the former, if there is an object in the context, with keyCARD
, and it is an instance of Card it most probably (>99%) is the transaction's card.Beta Was this translation helpful? Give feedback.
All reactions