Replies: 1 comment
-
Wouldn't hurt, but I don't think of a case where we use 'byte' as configuration. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
What do you think about implementing
@Config
for byte fields?We could add a:
And maybe something similar, but would involve a for loop, for a byte array property.
Or we could add a default implementation for
Configuration.getByte()
. And the same forshort
.to:
jPOS/jpos/src/main/java/org/jpos/q2/QFactory.java
Lines 458 to 478 in f047169
My motivation is just to lower the boilerplate to configure pinblock formats in a participant. Maybe the byte array support is overkilling, but the plain
byte
support seems to worth the effort.The short array may be more reasonable to support easy configuration of MiniGL, layers for example and since we are at it, we can implement all of them.
I'm willing to implement the PR if agreed.
Beta Was this translation helpful? Give feedback.
All reactions