Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try split entries of date-adapters #4471

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Dec 2, 2024

Try to fix #4468

0.0.0-snapshot-20241202180035 does work with a simple vite set up when running npm run dev...

Would be better for the output doesn't have sub directory under each dist (second LIB) in dist/{LIB}/dist-[cjs|es|types]/{LIB}

Test with codesandbox

--
Doesn't work with subfolder from 0.0.0-snapshot-20241202175046 snapshot ...

[plugin:vite:import-analysis] Failed to resolve import "@salt-ds/date-adapters/date-fns" from "src/App.tsx". Does the file exist?
/Users/F692193/projects/temp/vite-salt 2/src/App.tsx:11:31
21 | } from "react";
22 | import { SaltProvider } from "@salt-ds/core";
23 | import { AdapterDateFns } from "@salt-ds/date-adapters/date-fns";

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 0a883dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@salt-ds/date-adapters Minor
@salt-ds/lab Patch
@salt-ds/data-grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 6:04pm

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

github-actions bot commented Dec 2, 2024

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

github-actions bot commented Dec 2, 2024

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

github-actions bot commented Dec 2, 2024

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date libraries are not optional when using @salt-ds/date-adapters with Vite
1 participant