Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link component can provide it's own implementation of anchor tag (as per NavigationItem) #3627

Open
1 task
mark-tate opened this issue Jun 24, 2024 · 8 comments · May be fixed by #4325
Open
1 task

Link component can provide it's own implementation of anchor tag (as per NavigationItem) #3627

mark-tate opened this issue Jun 24, 2024 · 8 comments · May be fixed by #4325
Labels
component: link good first issue Good for newcomers status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: enhancement 💡 New feature or request

Comments

@mark-tate
Copy link
Contributor

mark-tate commented Jun 24, 2024 •
edited
Loading

Area

UI Components

The problem

Add render prop/patten to Link component

With NavigationItem, we can now provide an alternate link to the NavigationItem through the render prop. Emulate this behaviour for Link

The solution

Review NavigationItem API and render prop and emulate equivalent solution for Link

Alternatives and examples

  • Provider a 'Render Prop' and 'Render Element' example for your implementation
  • Update docs inline with how we documented NavigationItem

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@mark-tate mark-tate added status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: enhancement 💡 New feature or request labels Jun 24, 2024
@saurabhkacholiya
Copy link

saurabhkacholiya commented Jun 24, 2024 •
edited
Loading

Hi @mark-tate I would like to take up this issue. can you please assign it to me? and no I am not an employee of JPMorgan Chase & Co.

@mark-tate
Copy link
Contributor Author

mark-tate commented Jul 8, 2024 •
edited
Loading

Apologies for the slow response @saurabhkacholiya and thank you for your interest
We should implement this using the new renderProps approach provided in #3279.
Have a look at the PR and feedback.
We can then assign this this to you, once have you completed the CLA, that is required for all external contributors (or internal training if a JPM employee)

@mark-tate mark-tate closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@mark-tate mark-tate reopened this Jul 8, 2024
@ArchitGajjar
Copy link

Hi @mark-tate - can I work on this issue ?

  • Yes, I am an employee of JPMorgan Chase & Co.

@origami-z
Copy link
Contributor

Hi @mark-tate - can I work on this issue ?

  • Yes, I am an employee of JPMorgan Chase & Co.

Yes, feel free to contribute (assuming you've done the internal open source training)

@ArchitGajjar
Copy link

Sure, thank you @origami-z

@nidhi752
Copy link

nidhi752 commented Oct 1, 2024

hi, i would love to help in this issue.

@origami-z
Copy link
Contributor

hi, i would love to help in this issue.

Feel free to contribute a PR. If you're not part of JPMC, remember to follow CLA process from https://github.com/jpmorganchase/.github/blob/main/CONTRIBUTING.md

@mark-tate
Copy link
Contributor Author

Many offers of contribution so hoping that someone will provide the specified solution.
Have a look at NavigationItem's render api, would be a copy of that API.
Use this PR to discuss.

Feel free to contribute a PR. If you're not part of JPMC, remember to follow CLA process from https://github.com/jpmorganchase/.github/blob/main/CONTRIBUTING.md

Our own capacity will pick this up in Q1 otherwise.

@liamsms liamsms linked a pull request Oct 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: link good first issue Good for newcomers status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: enhancement 💡 New feature or request
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add render prop to Link liamsms/salt-ds
5 participants
@mark-tate @origami-z @ArchitGajjar @saurabhkacholiya @nidhi752