Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in code #1

Open
vixtor-qm opened this issue Jun 14, 2016 · 1 comment
Open

bug in code #1

vixtor-qm opened this issue Jun 14, 2016 · 1 comment

Comments

@vixtor-qm
Copy link

Hello, i have found a bug in the code that leaded to a crash of the entire node.

leddar.cpp:

line 39: it should be

 LeddarGetDetections(handler, detections, BEAM_COUNT); 

instead of

  LeddarGetDetections(handler, detections, sizeof(detections));

See original LeddarCDemo.cpp
They pass number of readings instead of actual size.

@jpmerc
Copy link
Owner

jpmerc commented Jun 27, 2016

It might have changed since I've used it. The code you see in leddartech.cpp is a copy of Leddartech's code on which I've added some code to convert the data to ROS laserscan message. You can see the original version of the code here (when I uploaded it to github): https://github.com/jpmerc/leddartech/blob/75f2cebe8f435c01e1983fb2c13a38fd65d519c0/SDK/LeddarCDemo/Main.c

I don't have access to a leddar anymore, so I suggest you to do a pull request with the working version and I'll merge it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants