Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for "match" option not up to date, maybe add a warning #51

Open
claradaia opened this issue Jun 3, 2024 · 0 comments
Open

Comments

@claradaia
Copy link

claradaia commented Jun 3, 2024

Hello,
First of all thank you for the package, super helpful!

I downloaded it today with ssc install, then encountered a few issues while attempting to use the match option and ended up here.

I can see that the documentation for match was updated here 1295d28, but the info I needed ("can't be used with the indicators option") does not show in the help page when I open it through Stata. ado update says the package is up to date, so perhaps something else needs to be done to update the docs in the registry?

Also, before I knew match could not be used with the indicators option, I ran the command and was just puzzled by the dataset not having the indicators. I believe it might be good to throw an error or at least a warning if the user tries to use both. If you agree, I can attempt to implement it and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant