Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare two arbitrary versions #26

Open
simon-brooke opened this issue Aug 25, 2017 · 7 comments
Open

Compare two arbitrary versions #26

simon-brooke opened this issue Aug 25, 2017 · 7 comments
Milestone

Comments

@simon-brooke
Copy link
Collaborator

Currently, you can compare any version of a file with the current version of that file; but you can't compare two arbitrary versions.

That should be possible.

@desolate-planet
Copy link
Contributor

Seems to be another issue. If I edit a wiki page. The first entry is listed in the history, but when I view the old version, the page is blank

@desolate-planet
Copy link
Contributor

If I proceed to add a second revision. The change made on the first revision becomes visible.

@simon-brooke
Copy link
Collaborator Author

H'mmm? That's not one I'm familiar with. Using this history, can you explain more clearly what you mean?

@desolate-planet
Copy link
Contributor

So, if I edit the main page i.e add a new line and save the edit. When I go to the history section and click on the "What's changed since?" link the page shows nothing.

@simon-brooke
Copy link
Collaborator Author

Aye. So, when you start a new instance of Smeagol, the git repo doesn't get created until you save the first page - so it doesn't hold any history before then.

I don't see that as a bug - after all, most people won't want to keep any of the distribution content, they'll want their wiki to show their own material.

@desolate-planet
Copy link
Contributor

Ok, cool. Just felt something was amiss when I edited the page, clicked save and the "what's changed" linked showed me a blank page. I would have thought the git repo would have been generated on the first edit. I'm still figuring out the code at the moment while working on my clojure stuff to get up to speed.

@simon-brooke simon-brooke added this to the 1.1.0.0 milestone Sep 9, 2017
@simon-brooke
Copy link
Collaborator Author

@desolate-planet, do you want to take this one on? I've marked it for the 1.1 release, so it's not urgent; and it will need some thinking through, both on the user interface side and in the algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants