shellcheck duplicates bashls

[baodrate]

when bashls is attached, its output duplicates shellcheck's. I noticed that the tsc config checks if tsserver is attached before generating diagnostics:

null-ls.nvim/lua/null-ls/builtins/diagnostics/tsc.lua

Lines 50 to 52 in c9348b4

	if client_id and vim.lsp.buf_is_attached(bufnr, client_id) then
	return
	end

should something similar be done, or is there a simpler way to stop them from clashing?

[polyzen]

Do not use shellcheck via null-ls if you're also using bash-ls, as bash-ls now supports shellcheck integration:
bash-lsp/bash-language-server@71c6a4a

[baodrate]

yes, I realize that. But I don't always have bashls attached/installed, and I share my config across many machines. Is there an obvious way to disable null-ls's shellcheck integration iff there is a bashls instance attached to the buffer?

[jose-elias-alvarez]

This is how I would do it:

vim.api.nvim_create_autocmd("LspAttach", {
    callback = function(args)
        local client = vim.lsp.get_client_by_id(args.data.client_id)
        if client and client.name == "bashls" then
            -- this a noop if shellcheck is not active
            -- if it is, it clears any diagnostics and prevents the source from running again
            require("null-ls").disable("shellcheck")
        end
    end,
})

Edit: for finer control, you could also do this using runtime_condition, but I'd recommend the first approach if you don't need to handle more complex cases (e.g. starting and stopping the bashls server).

[baodrate]

That's exactly what I was looking for, thank you!

(can't mark this reply as the answer tho, I guess I'll mark the parent)

I don't like how that shows up, do you mind reposting as a separate answer so it gets the nice preview at the top? 😅

[mmirus]

I ran into this as well and decided on a different solution. Because shellcheck via null-ls supports code actions (for disabling rules) and bashls does not, instead of disabling the null-ls shellcheck I disabled the bashls shellcheck.

You can do this by giving bashls an empty string for bashIde.shellcheckPath in the LSP config.

For example:

require("lsp-zero").configure("bashls", {
  settings = {
    bashIde = {
      shellcheckPath = "",
    },
  },
})

[baodrate]

I actually did disable bashls eventually for similar reasons. this is a good idea, thanks!