-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for ref
properties
#185
Open
mcjazzyfunky
wants to merge
3
commits into
jorgebucaran:main
Choose a base branch
from
mcjazzyfunky:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,138 @@ | ||
import { t as tw, equal } from "twist" | ||
import { JSDOM } from "jsdom" | ||
import { h, patch } from "../index.js" | ||
|
||
// we enhance twist's original function `t` | ||
// with support for generator functions as source | ||
// for tests as alternative to arrays | ||
function t(name, tests) { | ||
return tw(name, Array.isArray(tests) ? tests : Array.from(tests())) | ||
} | ||
|
||
// === ref helpers ==================================================== | ||
|
||
function createRefObject() { | ||
let current = null | ||
let previous = null | ||
|
||
return { | ||
get current() { | ||
return current | ||
}, | ||
|
||
set current(value) { | ||
previous = current | ||
current = value | ||
}, | ||
|
||
get previous() { | ||
return previous | ||
} | ||
} | ||
} | ||
|
||
function createRefCallback() { | ||
let current = null | ||
let previous = null | ||
|
||
const ret = (value) => { | ||
previous = current | ||
current = value | ||
} | ||
|
||
Object.defineProperties(ret, { | ||
current: { get: () => current }, | ||
previous: { get: () => previous } | ||
}) | ||
|
||
return ret | ||
} | ||
|
||
// === tests ========================================================= | ||
|
||
export default [ | ||
t("ref support for superfine", [ | ||
t("test ref helpers (only needed for testing)", [ | ||
t("testing createRefObject", function* () { | ||
const refObject = createRefObject() | ||
yield equal(refObject.current, null) | ||
yield equal(refObject.previous, null) | ||
|
||
refObject.current = 11 | ||
yield equal(refObject.current, 11) | ||
yield equal(refObject.previous, null) | ||
|
||
refObject.current = 22 | ||
yield equal(refObject.current, 22) | ||
yield equal(refObject.previous, 11) | ||
|
||
refObject.current = 33 | ||
yield equal(refObject.current, 33) | ||
yield equal(refObject.previous, 22) | ||
}), | ||
t("testing createRefCallback", function* () { | ||
const refCallback = createRefCallback() | ||
yield equal(refCallback.current, null) | ||
yield equal(refCallback.previous, null) | ||
|
||
refCallback(111) | ||
yield equal(refCallback.current, 111) | ||
yield equal(refCallback.previous, null) | ||
|
||
refCallback(222) | ||
yield equal(refCallback.current, 222) | ||
yield equal(refCallback.previous, 111) | ||
|
||
refCallback(333) | ||
yield equal(refCallback.current, 333) | ||
yield equal(refCallback.previous, 222) | ||
}), | ||
]), | ||
t("test behavior of refs", [ | ||
t("ref objects and ref callbacks should work properly", function* () { | ||
const container = new JSDOM('<div id="root"><span><span></div>') | ||
.window.document.getElementById('root') | ||
|
||
const render = (vnode) => patch(container.firstChild, vnode) | ||
const refObject = createRefObject() | ||
const refCallback = createRefCallback() | ||
|
||
render(h("div", { ref: refObject })) | ||
yield equal(refObject.current?.tagName, "DIV") | ||
yield equal(refObject.previous, null) | ||
yield equal(refCallback.current, null) | ||
yield equal(refCallback.previous, null) | ||
|
||
render(h("input", { ref: refCallback })) | ||
yield equal(refObject.current, null) | ||
yield equal(refObject.previous?.tagName ,"DIV") | ||
yield equal(refCallback.current?.tagName ,"INPUT") | ||
yield equal(refCallback.previous, null) | ||
|
||
render(h("input", { ref: refCallback })) | ||
yield equal(refObject.current, null) | ||
yield equal(refObject.previous?.tagName, "DIV") | ||
yield equal(refCallback.current?.tagName, "INPUT") | ||
yield equal(refCallback.previous, null) | ||
|
||
render(h("button", { ref: refObject })) | ||
yield equal(refObject.current?.tagName, "BUTTON") | ||
yield equal(refObject.previous, null) | ||
yield equal(refCallback.current, null) | ||
yield equal(refCallback.previous?.tagName, "INPUT") | ||
|
||
render(h("button", { ref: refCallback })) | ||
yield equal(refObject.current, null) | ||
yield equal(refObject.previous?.tagName, "BUTTON") | ||
yield equal(refCallback.current?.tagName ,"BUTTON") | ||
yield equal(refCallback.previous, null) | ||
|
||
render(h("input", { ref: refCallback })) | ||
yield equal(refObject.current, null) | ||
yield equal(refObject.previous?.tagName, "BUTTON") | ||
yield equal(refCallback.current?.tagName, "INPUT") | ||
yield equal(refCallback.previous, null) | ||
}) | ||
]) | ||
]) | ||
] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need generators to test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this may have been a misunderstanding on my side.
I was of the impression that in
twist
"one test" means "one invocation of a twist assert function", so this refs test file would contain a bit more than 40 tests ... and to be count properly in the summary I had toyield
each single one of them.Normally I would say this refs test file contains only three tests (with over 40 assertions).
Please show me a few lines on code how this is to be done with
twist
normally - thanks - and I will fix it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! If we merge this feature, I'll take care of the tests myself. 🙆♂️