Added support for ref properties
#185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import { JSDOM } from "jsdom" | ||
| import { h, patch } from "../index.js" | ||
|
|
||
| // we enhance twist's original function `t` |
There was a problem hiding this comment.
Why do we need generators to test this?
There was a problem hiding this comment.
I guess this may have been a misunderstanding on my side.
I was of the impression that in twist "one test" means "one invocation of a twist assert function", so this refs test file would contain a bit more than 40 tests ... and to be count properly in the summary I had to yield each single one of them.
Normally I would say this refs test file contains only three tests (with over 40 assertions).
Please show me a few lines on code how this is to be done with twist normally - thanks - and I will fix it.
There was a problem hiding this comment.
No worries! If we merge this feature, I'll take care of the tests myself. 🙆♂️
jorgebucaran
changed the title
ref properties (see #184)ref properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jorgebucaran Could you please review?