Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect features for MusicCNN models (pypi version) #20

Open
romi1502 opened this issue Jun 29, 2021 · 1 comment
Open

Incorrect features for MusicCNN models (pypi version) #20

romi1502 opened this issue Jun 29, 2021 · 1 comment

Comments

@romi1502
Copy link

romi1502 commented Jun 29, 2021

The pypi version of musicnn still contains a bug that was fixed
in this commit, but not deployed on pypi.
Then extracting the penultimate layer output using the extractor function with extract_features=True results in incorrect outputs with the pypi version.

@romi1502 romi1502 changed the title Incorrect features for MusicCNN models Incorrect features for MusicCNN models (pypi version) Jun 29, 2021
@suncerock
Copy link

Similar issue found in both the pypi version and the main branch
Think this line

predicted_tags, timbral_, temporal_, midend1_, midend2_, midend3_, mean_pool_, max_pool_, penultimate_ = tf_out

should be
predicted_tags, timbral_, temporal_, cnn1_, cnn2_, cnn3_, mean_pool_, max_pool_, penultimate_ = tf_out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants