Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rangeIncomplete fires after clearing BOTH time pickers #96

Open
jkallay1 opened this issue Jun 1, 2017 · 2 comments
Open

rangeIncomplete fires after clearing BOTH time pickers #96

jkallay1 opened this issue Jun 1, 2017 · 2 comments

Comments

@jkallay1
Copy link
Contributor

jkallay1 commented Jun 1, 2017

Starting with a time set in both time pickers, the event fires after clearing one and then again after clearing the other. This is semantically incorrect, as having an entirely empty range is different from having one with only one value.

@jonthornton
Copy link
Owner

Can you provide a use case for this? Is it causing problems as you build your app?

@jkallay1
Copy link
Contributor Author

Yes. I'm using the rangeIncomplete event to mark the control as invalid and the rangeSelected event to mark it as valid for client-side validation purposes. This bug requires a special check for the case where both fields are empty in the rangeIncomplete handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants