Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oat-record --interactive does not exit when source dies #20

Open
jonnew opened this issue May 26, 2016 · 0 comments
Open

Oat-record --interactive does not exit when source dies #20

jonnew opened this issue May 26, 2016 · 0 comments
Labels
bug

Comments

@jonnew
Copy link
Owner

jonnew commented May 26, 2016

The default behavior in oat components is to close when the upstream data source exits. When oat-record is in interactive mode, it does not do this because std::getline blocks. It requires the user to put some input into the terminal so std::getline() unblocks,
@jonnew jonnew added the bug label May 26, 2016
jonnew pushed a commit that referenced this issue Jul 4, 2016
Partially functional solution to #20
4364184 
- Streams as defined in std are blocking objects.
- Polling them for available characters is difficult because of this
- I've managed to get polling working for stdin and therefore get
  oat-record to exit when an input SOURCE dies in interactive mode.
  However, this solution does not work for the custom istream I have
  defined for ZMQ input. I think I'm on the right track, but its not
  there yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonnew