Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization Docker files and builds instructions #732

Open
beniz opened this issue May 11, 2020 · 0 comments
Open

Reorganization Docker files and builds instructions #732

beniz opened this issue May 11, 2020 · 0 comments

Comments

@beniz
Copy link
Collaborator

beniz commented May 11, 2020

PR #706 greatly improved the docker images. However, we need a second pass to clean up / reorganize some elements. See the list below:

  • the build dir is often volatile in projects that use cmake. I suggest that it is turned into docker as before the PR as it hosts the Docker build documentation as well.
  • the *.Dockerfile should not be at the root of the repository, let's have them into the docker directory above.
  • if the build.sh script is generic enough that it can be used as an alternative to the building steps we outline in the documentation, then it could/should go at the root of the repository. If this script eases all builds, then we could re-write the build documentation accordingly in README.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant