You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This line seems to be the source of the trouble. The regex only accounts for line comments or line end after the path. The spec for sample paths makes it fairly tricky to parse correctly. The only condition is that the path can't contain the "=" character. If you change this regex to "(?=(\\s\/\/|\\s\/\\*|\\s\\w*\\=|$))", it will additionally handle the cases where the path is followed by another opcode or a block comment. This covers all the cases I've run into where the highlighting was broken.
The result of this change is the opcodes are highlighted correctly.
The text was updated successfully, but these errors were encountered:
This is what the issue looks like. The opcodes following the sample path are not highlighted correctly.
vscode-sfz/syntaxes/sfz.tmLanguage.json
Line 79 in 5242e29
This line seems to be the source of the trouble. The regex only accounts for line comments or line end after the path. The spec for sample paths makes it fairly tricky to parse correctly. The only condition is that the path can't contain the "=" character. If you change this regex to
"(?=(\\s\/\/|\\s\/\\*|\\s\\w*\\=|$))"
, it will additionally handle the cases where the path is followed by another opcode or a block comment. This covers all the cases I've run into where the highlighting was broken.The result of this change is the opcodes are highlighted correctly.
The text was updated successfully, but these errors were encountered: