Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it necessary for electron-prebuilt to be a hard dependency? #86

Open
octatone opened this issue Dec 3, 2018 · 1 comment
Open

Is it necessary for electron-prebuilt to be a hard dependency? #86

octatone opened this issue Dec 3, 2018 · 1 comment

Comments

@octatone
Copy link

octatone commented Dec 3, 2018 •
edited
Loading

I am running into issues in our CI with this specific dependency failing to download every so often, and it's not something we ever use. We use chromedriver exclusively. Can electron & electron-prebuilt be moved to optional dependencies?
@berickson1
Copy link

+1 running into issues with this as well. The download task inside electron-prebuild to grab from github releases is unreliable on my build machines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@octatone @berickson1