Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

NancyFx v2 support #1

Open
pdwetz opened this issue Apr 11, 2016 · 4 comments
Open

NancyFx v2 support #1

pdwetz opened this issue Apr 11, 2016 · 4 comments

Comments

@pdwetz
Copy link

pdwetz commented Apr 11, 2016

NancyFx version 2.0 has breaking interface changes which cause this library to fail. I have a local fork
in a "nancyfx2" branch which builds and has passing tests (some switched to async in mirror to the official JSON serializer). I can send as a pull request if desired. Obviously it shouldn't be put in master just yet, but it would be nice to have as a pre-release nuget if possible.

@joergbattermann
Copy link
Owner

Hi Peter! That would be great, yes 👍

I haven't really dug into Nancy 2 yet as it's still alpha but as 1.x won't see much change(s) anymore (if any), now is as good as any other time for a 2.0.0-alpha of this serializer... so yeah - just send the PR over.

I've created a new branch (NancyFx_v2), so if you could specify that one for the traget branch when you create the PR instead of master it would make it a tad easier to work with...

Cheers & thanks,
-Jörg

@pdwetz
Copy link
Author

pdwetz commented Apr 11, 2016

The GitHub app threw an error saying I don't have permission to send a pull request to the repo. From the wording of the message, though, I'm unclear if they're having server issues and it was unable to determine my permissions, or if you have the repo locked down.

@joergbattermann
Copy link
Owner

Is it possible that your 'source' repository is hidden or not really 'forked' from mine? I can't see it listed under your repositories at https://github.com/pdwetz?tab=repositories either...

@pdwetz
Copy link
Author

pdwetz commented Apr 12, 2016

Sorry, too much work in just my own repos lately, so had a few false starts. Added pull request properly now (I think).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants