Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The AbstractCompile.destinationDir property has been deprecated #1646

Open
surecloud-jleite opened this issue Nov 18, 2024 · 2 comments · May be fixed by #1658
Open

The AbstractCompile.destinationDir property has been deprecated #1646

surecloud-jleite opened this issue Nov 18, 2024 · 2 comments · May be fixed by #1658

Comments

@surecloud-jleite
Copy link

I've got this warning when using Gradle 8.11

The AbstractCompile.destinationDir property has been deprecated.org.jsonschema2pojo

This is scheduled to be removed in Gradle 9.0.
The AbstractCompile.destinationDir property has been deprecated.
@unkish
Copy link
Collaborator

unkish commented Dec 10, 2024

Hi

Since jsonschema2pojo-gradle-plugin does not explicitly reference AbstractCompile#destinationDir then theoretically given warning should not pose a problem.

I've managed to trace down the source/location of given warning to

jsonschema2pojo/jsonschema2pojo-gradle-plugin/src/main/groovy/org/jsonschema2pojo/gradle/GenerateJsonSchemaJavaTask.groovy

Line 88 in 50b2fca

configuration.targetVersion = compileJavaTask.getProperties().get("sourceCompatibility")

It looks like that warning is emited due usage of meta properties field (.properties()).
Replacing it with

configuration.targetVersion = compileJavaTask.sourceCompatibility

would make warning go away.

@joelittlejohn what would be your opinion here - should the change be applied or it's not worth it ?

@joelittlejohn
Copy link
Owner

Thanks for digging into this @unkish. Yes, this looks like a good change to me.

@unkish unkish linked a pull request Dec 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@joelittlejohn @unkish @surecloud-jleite