-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Safari #25
Comments
Thanks! I have looked into releasing it for Safari a while ago, but I don't have a Mac. I did try converting it once with my brother's MacBook, but it had some issues and I didn't have time to make it fully work. I'll try again next time I see him. That's cool you got it working though. I'm curious, how well does it run, what settings don't work? |
I'll have to look into more, but it seems that almost all the the functionality works perfectly fine (New and Old). One UI element I noticed, the "Show Navigation Buttons for Next/Previous Root comment", loads pretty far to the left, but are completely usable. The only thing I couldn't see if it worked was Backup/Restore, as they did nothing upon pressing them. Overall, I am REALLY happy with how well it works on Safari, and was super simple to build. Here is a test build of the app for people who wanted to test it out: https://github.com/kalyway101/RedditEnhancer-Safari/blob/main/Reddit%20Enhancer.app.zip Make sure you enable Unsigned Extensions in Safari (Settings->Developer->Allow Unsigned Extensions) |
That's great to hear it mostly just works! I'll fix any bugs and publish it officially to the App Store when I get the chance, but in the meantime it's good to have a build available for people to install. Thank you :) |
I love this extension and it works well. I was wondering if it would be possible to slightly tweak it for Safari's usage?
I was actually able to convert it to Safari using Apple's dev tools, and it works well for most settings: https://developer.apple.com/documentation/safariservices/safari_web_extensions/converting_a_web_extension_for_safari/
Cheers!
The text was updated successfully, but these errors were encountered: