Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huge tidy up of code after we take all the PRs #356

Open
mpentler opened this issue Oct 21, 2018 · 3 comments
Open

Huge tidy up of code after we take all the PRs #356

mpentler opened this issue Oct 21, 2018 · 3 comments

Comments

@mpentler
Copy link
Collaborator

A lot of things have been messed up with recent PRs due to my ineptitude. When the majority of these PRs are taken/dealt with we'll need to reorder everything to make it nice and tidy.
@mpentler
Copy link
Collaborator Author

My notes for later:

-check the ALL_FACTS tuple
-check the readme list
-check the regex list
-check the facts list
-are they all in alphabetical order

@mpentler
Copy link
Collaborator Author

#358 is a first stab at this but more will come.

@mpentler
Copy link
Collaborator Author

mpentler commented Jan 2, 2019

5c83991
25310d4
9f6de85

Started work on this and we're good for A through M. Will do N through Z tonight. Then I'll check to make sure they're all in order.

I'm being naughty and committing direct to master for this because I am lazy and my dev platform is toast at the moment.

@mpentler mpentler mentioned this issue Jan 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpentler