Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implement email integration #8

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jkarenzi
Copy link
Owner

@jkarenzi jkarenzi commented Jun 13, 2024

What does this PR do?

This PR implements email integration. The functionality of sending emails is used in email verification and two factor authentication.

Description of the task to be completed

  • Email integration with mailgun or any other provider
  • Implement email verification as an additional step after signing up. Unverified users should login but shouldn't be able to access the majority of the app's features
  • Implement 2FA upon login, for users who requested that additional step
  • Write appropriate documentation for resulting endpoints
  • Implement appropriate error handling and responses
  • Write comprehensive unit tests

How can this be manually tested?

  • Upon signup, a new user should receive an email, asking them to verify their email
  • Upon login, if 2FA is enabled, a user will receive a code on their email, which they will use to continue with the authentication process

Swagger documentation screenshot
qqqqq

Test screenshot

aaaaa

What are the relevant pivotal trackers/story id?

@jkarenzi jkarenzi added the feature New feature or request label Jun 13, 2024
@jkarenzi jkarenzi added this to the Sprint 1 milestone Jun 13, 2024
@jkarenzi jkarenzi self-assigned this Jun 13, 2024
@jkarenzi jkarenzi force-pushed the ft-email-verification-and-2fa-#4 branch from 627452a to bba78d9 Compare June 13, 2024 14:45
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 89.52381% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.50%. Comparing base (c1d809f) to head (55fee53).

Files Patch % Lines
src/utils/sendEmail.ts 45.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
- Coverage   100.00%   92.50%   -7.50%     
===========================================
  Files           10       13       +3     
  Lines           84      200     +116     
  Branches         5       16      +11     
===========================================
+ Hits            84      185     +101     
- Misses           0       14      +14     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

-implement email verification
- implement two factor authentication
- add swagger documentation
- refactor tests to run in a docker container

[Delivers #4]
@jkarenzi jkarenzi force-pushed the ft-email-verification-and-2fa-#4 branch from 52d4d1f to 55fee53 Compare June 13, 2024 19:09
@jkarenzi jkarenzi linked an issue Jun 13, 2024 that may be closed by this pull request
6 tasks
@jkarenzi jkarenzi merged commit b20ee9a into develop Jun 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Email verification and Two factor Authentication
1 participant