Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods shouldn't be forced to public #7

Open
ShawnTheBeachy opened this issue Aug 19, 2024 · 0 comments · May be fixed by #9
Open

Methods shouldn't be forced to public #7

ShawnTheBeachy opened this issue Aug 19, 2024 · 0 comments · May be fixed by #9

Comments

@ShawnTheBeachy
Copy link

99% of the time that I'm mapping from an IDataReader to a model, I'm doing it with an accessor of internal. However, the generated extension method is public, which means my model is also forced to be public. This means that both the extension method and the model show up in auto-complete when I'm working in a project that references the project where I'm using the reader. It would be great if the GenerateDataReaderMapper allowed us to at least set the accessibility to internal, if it doesn't default to it.

@amyskippy amyskippy linked a pull request Oct 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant