From 195d376577c2b52988cee02402e5d26100f40364 Mon Sep 17 00:00:00 2001 From: XXIV <13811862+thechampagne@users.noreply.github.com> Date: Tue, 26 Sep 2023 10:53:31 +0300 Subject: [PATCH] fix(consensus): free allocated CStrings (#6054) --- jina/serve/consensus/run.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/jina/serve/consensus/run.go b/jina/serve/consensus/run.go index 22bdd54e4adb9..9e4c0880b7ddb 100644 --- a/jina/serve/consensus/run.go +++ b/jina/serve/consensus/run.go @@ -374,7 +374,9 @@ func add_voter(self *C.PyObject, args *C.PyObject) *C.PyObject { err := AddVoter(C.GoString(target), C.GoString(raftId), C.GoString(voterAddress)) if err != nil { logger.Error("Error received calling AddVoter", "error", err) - C.raise_exception(C.CString("Error from AddVoter")) + cerr := C.CString("Error from AddVoter") + defer C.free(unsafe.Pointer(cerr)) + C.raise_exception(cerr) return nil } } @@ -455,6 +457,8 @@ func get_configuration(self *C.PyObject, args *C.PyObject) *C.PyObject { return pyStr } - C.raise_exception(C.CString("Error from get_configuration, wrong parameters passed")) + cerr := C.CString("Error from get_configuration, wrong parameters passed") + defer C.free(unsafe.Pointer(cerr)) + C.raise_exception(cerr) return nil }