Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance React i18n module #11002

Open
fabienpuissant opened this issue Sep 28, 2024 · 2 comments
Open

Enhance React i18n module #11002

fabienpuissant opened this issue Sep 28, 2024 · 2 comments

Comments

@fabienpuissant
Copy link
Collaborator

To follow the idea of what have been done in the VueI18nModule, the React one module needs the be adapted.

  • Use a setup file to mock react i18n for all tests
  • Separate translations to be scoped to each bounded context in separate translation files
@fabienpuissant
Copy link
Collaborator Author

fabienpuissant commented Nov 10, 2024

@DamnClin @Gnuk

We need to decide what we want for front translation design (#11111)

Vue Ts configuration with multiple bounded context files

React one json file with all translations

Because rn, React and Vue are not aligned and I would like to make them work the same way 😃

@Gnuk
Copy link
Collaborator

Gnuk commented Nov 11, 2024

I think you can split translations by context. If it's easier to be consistent with JSON, we can start with it and maybe later (in the future) we will be able to use typescript type system to check translation keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants