Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startTransmit make data arg constant #1156

Closed
dizcza opened this issue Jul 9, 2024 · 2 comments
Closed

startTransmit make data arg constant #1156

dizcza opened this issue Jul 9, 2024 · 2 comments
Labels
enhancement New feature or request resolved Issue was resolved (e.g. bug fixed, or feature implemented)

Comments

@dizcza
Copy link

dizcza commented Jul 9, 2024

All startTransmit functions should accept the constant uint8_t* data.

I've gone through their implementation but am still not sure if I can safely cast my constant data buffer to be modifiable and expect that it won't be changed inside the startTransmit functionality.

@jgromes
Copy link
Owner

jgromes commented Jul 9, 2024

No modifications to the user buffer are done within startTransmit, so yes, const uint8_t* data is the more proper way to go.

@jgromes jgromes added the enhancement New feature or request label Jul 9, 2024
@jgromes
Copy link
Owner

jgromes commented Jul 13, 2024

Added in the mentioned commit - this is likely going to cause a new minor release as the public API has changed in a way that may throw some people off.

@jgromes jgromes closed this as completed Jul 13, 2024
@jgromes jgromes added the resolved Issue was resolved (e.g. bug fixed, or feature implemented) label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resolved Issue was resolved (e.g. bug fixed, or feature implemented)
Projects
None yet
Development

No branches or pull requests

2 participants