Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[artifactory-ha] update nginx TLS config #1109

Closed
wants to merge 1 commit into from

Conversation

dhutty
Copy link

@dhutty dhutty commented Sep 16, 2020

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:
As discussed with [email protected], this brings the nginx TLS config into line with the "Intermediate" recommendations from https://ssl-config.mozilla.org

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@eldada
Copy link
Contributor

eldada commented Sep 17, 2020

Artifactory has many other, older clients that use it. Much more than web browsers.
Some of these are fairly old, and we try and keep support for a fairly wide range of clients.
I'm worried that this change might actually break this.
I suggest you wrap this configuration in an if clause with an option to select turning it on or off.
I'll also take it internally to see if we can verify this somehow.

@gitta-jfrog
Copy link
Collaborator

We decided not to take this change. In any case, customers can pass their own custom "artifactoryConf". Thanks!

@gitta-jfrog gitta-jfrog closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants