-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package for Java #120
Comments
@matusfaro, great idea! I don't have any experience publishing to maven, but it looks like it's relatively simple with projen. See here. Could you test out deploying it to maven and then if there are no hiccups we can publish it officially within this repo? |
@bestickley It was surprisingly easy to compile and package a JAR file, so the two outstanding issues are to test that it actually works and publishing to Maven Central. Within a week or so I should confirm whether I can successfully deploy a NextJS site, I will post back when I do. As for Maven Central publishing, this is something you would have to do on your own (I can guide you). Alternatively, I could publish it to Maven Central if you don't have the time, but it would be under my own group id, not I posted the high-level steps in #121 first would be to send a request to Sonatype to get permission to publish a package under |
@revmischa, are you able to do the above? I don't want to speak out of turn for JetBridge. |
I would just use your own identifier instead of com.jetbridge |
@revmischa @bestickley Which option do you prefer?
Edit: Forked it and made availble for Java, Go, Python, .NET |
@matusfaro, I'd say we go with 2. for now. This is a 2-way door decision. We can create an "official" com.jetbridge later if desired. |
2 sounds chill to me |
@matusfaro, I see you've made good progress on open-next-cdk. But I think it would be smart to consolidate efforts. Is there any way you could incorporate your changes upstream? |
did the above happen? also interested in using these constructs outside of js, specifically looking for a python release (happy to assist if additional effort is needed). |
Fantastic, appreciate it. Agreed re: your naming related issue, these are deployment constructs and the "standalone" option may not be relevant to future nextjs releases this supports. |
@jaismith, you're welcome! That's a great reason to ditch standalone. Do you mind commenting that on discussion? |
Hello, i happened to run into this Repo today and was amazed by the results and the effort that has went into the NextJs Construct. One thing that I would like to see is a pip package of cdk-nextjs. I've tried packaging it using projen for PyPi which worked without any issue, I now locally have my own gzip which I was able to use in my python CDK Application without any issues. Seeing as I've already made the needed changes locally, can I submit a PR? A maintainer would have to supply the credentials to be able push the package to PyPi. Is this something you would be interested in doing? |
Hi @MohanadAbugharbia, PR would be great! Thank you. |
I am evaluating to either package this project for Java or create a separate simplistic Java CDK Construct for OpenNext.
As I am unfamiliar with JSII, do you know how much more effort is needed in this project to be packaged for Java using JSII?
Thanks in advance!
The text was updated successfully, but these errors were encountered: