Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package for Java #120

Open
matusfaro opened this issue Jul 13, 2023 · 14 comments
Open

Package for Java #120

matusfaro opened this issue Jul 13, 2023 · 14 comments

Comments

@matusfaro
Copy link

I am evaluating to either package this project for Java or create a separate simplistic Java CDK Construct for OpenNext.

As I am unfamiliar with JSII, do you know how much more effort is needed in this project to be packaged for Java using JSII?

Thanks in advance!

@matusfaro matusfaro changed the title Package for Java (and Python, .NET) Package for Java Jul 13, 2023
@bestickley
Copy link
Contributor

@matusfaro, great idea! I don't have any experience publishing to maven, but it looks like it's relatively simple with projen. See here.

Could you test out deploying it to maven and then if there are no hiccups we can publish it officially within this repo?

@matusfaro
Copy link
Author

@bestickley It was surprisingly easy to compile and package a JAR file, so the two outstanding issues are to test that it actually works and publishing to Maven Central.

Within a week or so I should confirm whether I can successfully deploy a NextJS site, I will post back when I do.

As for Maven Central publishing, this is something you would have to do on your own (I can guide you). Alternatively, I could publish it to Maven Central if you don't have the time, but it would be under my own group id, not com.jetbridge.

I posted the high-level steps in #121 first would be to send a request to Sonatype to get permission to publish a package under com.jetbridge which takes a few days. Also to confirm, I assume you are able to add a DNS entry for jetbridge.com for verification purposes on Sonatype?

@bestickley
Copy link
Contributor

@revmischa, are you able to do the above? I don't want to speak out of turn for JetBridge.

@revmischa
Copy link
Member

I would just use your own identifier instead of com.jetbridge

@matusfaro
Copy link
Author

matusfaro commented Jul 13, 2023

@revmischa @bestickley Which option do you prefer?

  1. Bestickley could create his own identifier under his domain and publish it from this repo
  2. I can use my existing identifier io.dataspray, fork this repository and publish from there (No additional work for you)

Edit: Forked it and made availble for Java, Go, Python, .NET

@bestickley
Copy link
Contributor

@matusfaro, I'd say we go with 2. for now. This is a 2-way door decision. We can create an "official" com.jetbridge later if desired.

@revmischa
Copy link
Member

2 sounds chill to me

@bestickley
Copy link
Contributor

@matusfaro, I see you've made good progress on open-next-cdk. But I think it would be smart to consolidate efforts. Is there any way you could incorporate your changes upstream?
If the only reason for creating the new package is for you to be able to publish packages to other registries, could we make you a maintainer of this project so you can do the same here?
What do you think?

@jaismith
Copy link

jaismith commented Dec 27, 2023

did the above happen? also interested in using these constructs outside of js, specifically looking for a python release (happy to assist if additional effort is needed).

@bestickley
Copy link
Contributor

bestickley commented Dec 27, 2023

@jaismith, the above did not happen. However, I will create a package in PyPI for you. I'm targeting to get it done within the week.
Related: #191

@jaismith
Copy link

Fantastic, appreciate it. Agreed re: your naming related issue, these are deployment constructs and the "standalone" option may not be relevant to future nextjs releases this supports.

@bestickley
Copy link
Contributor

@jaismith, you're welcome! That's a great reason to ditch standalone. Do you mind commenting that on discussion?

@MohanadAbugharbia
Copy link

@jaismith, the above did not happen. However, I will create a package in PyPI for you. I'm targeting to get it done within the week. Related: #191

Hello, i happened to run into this Repo today and was amazed by the results and the effort that has went into the NextJs Construct.

One thing that I would like to see is a pip package of cdk-nextjs.

I've tried packaging it using projen for PyPi which worked without any issue, I now locally have my own gzip which I was able to use in my python CDK Application without any issues.

Seeing as I've already made the needed changes locally, can I submit a PR? A maintainer would have to supply the credentials to be able push the package to PyPi. Is this something you would be interested in doing?

@bestickley
Copy link
Contributor

Hi @MohanadAbugharbia, PR would be great! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants