Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectedLineBgColor always uses bright colours; default theme is illegible in white-on-black terminals #543

Open
unikitty37 opened this issue Jun 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@unikitty37
Copy link

unikitty37 commented Jun 7, 2024

Describe the bug
The selectedLineBgColor setting always seems to use bright colours. While that might work for people using dark text on a light background, it makes most of the options illegible when using dark backgrounds. In particular, there's hardly any difference between blue and cyan, whereas a dark blue background would be ideal.

The list of colour attributes doesn't seem to mention any way of selecting dark variants vs bright variants.

Setting red is a workaround; it's still pretty low-contrast, though. (Not to mention having a bright red bar always in a corner of the screen is a bit distracting, as I keep thinking something has failed!)

To Reproduce
Steps to reproduce the behaviour:

  1. Configure your terminal theme to be white text on a black background.
  2. Launch lazydocker with an empty config file.
  3. Press x to open the menu, which has all-white text.
  4. Try to read the currently-selected item.

Expected behaviour
The currently-selected item is

Screenshots
blue:

image

cyan:

image

red:

image

Desktop (please complete the following information):

  • OS: macOS 14.5 (23F79)
  • Lazydocker Version v0.23.3
  • The last commit id if you built project from sources (run : git rev-parse HEAD) [binary release]

Additional context
I guess lazydocker has no way of detecting whether the terminal has a dark or light background, and I don't believe there's an environment variable that's conventionally used to indicate this.

Allowing colour names to be prefixed with dark or bright to choose a specific variant might be useful. Adding a config option for selectedLineFgColor might work, too, as I could just set that to black.

OTOH, I'm using iTerm2 and my $TERM is xterm-256color, so support for the full range of 256 colours would be ideal :)

@unikitty37 unikitty37 added the bug Something isn't working label Jun 7, 2024
@unikitty37
Copy link
Author

Hm — on reading the docs for lazygit, I see hex values are valid as well, and that's let me choose something that works. If only I'd set that up first :)

It might be worth mentioning the hex option in the docs for lazydocker as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant