You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The selectedLineBgColor setting always seems to use bright colours. While that might work for people using dark text on a light background, it makes most of the options illegible when using dark backgrounds. In particular, there's hardly any difference between blue and cyan, whereas a dark blue background would be ideal.
The list of colour attributes doesn't seem to mention any way of selecting dark variants vs bright variants.
Setting red is a workaround; it's still pretty low-contrast, though. (Not to mention having a bright red bar always in a corner of the screen is a bit distracting, as I keep thinking something has failed!)
To Reproduce
Steps to reproduce the behaviour:
Configure your terminal theme to be white text on a black background.
Launch lazydocker with an empty config file.
Press x to open the menu, which has all-white text.
Try to read the currently-selected item.
Expected behaviour
The currently-selected item is
Screenshots blue:
cyan:
red:
Desktop (please complete the following information):
OS: macOS 14.5 (23F79)
Lazydocker Version v0.23.3
The last commit id if you built project from sources (run : git rev-parse HEAD) [binary release]
Additional context
I guess lazydocker has no way of detecting whether the terminal has a dark or light background, and I don't believe there's an environment variable that's conventionally used to indicate this.
Allowing colour names to be prefixed with dark or bright to choose a specific variant might be useful. Adding a config option for selectedLineFgColor might work, too, as I could just set that to black.
OTOH, I'm using iTerm2 and my $TERM is xterm-256color, so support for the full range of 256 colours would be ideal :)
The text was updated successfully, but these errors were encountered:
Hm — on reading the docs for lazygit, I see hex values are valid as well, and that's let me choose something that works. If only I'd set that up first :)
It might be worth mentioning the hex option in the docs for lazydocker as well.
Describe the bug
The
selectedLineBgColor
setting always seems to use bright colours. While that might work for people using dark text on a light background, it makes most of the options illegible when using dark backgrounds. In particular, there's hardly any difference betweenblue
andcyan
, whereas a dark blue background would be ideal.The list of colour attributes doesn't seem to mention any way of selecting dark variants vs bright variants.
Setting
red
is a workaround; it's still pretty low-contrast, though. (Not to mention having a bright red bar always in a corner of the screen is a bit distracting, as I keep thinking something has failed!)To Reproduce
Steps to reproduce the behaviour:
x
to open the menu, which has all-white text.Expected behaviour
The currently-selected item is
Screenshots
blue
:cyan
:red
:Desktop (please complete the following information):
git rev-parse HEAD
) [binary release]Additional context
I guess lazydocker has no way of detecting whether the terminal has a dark or light background, and I don't believe there's an environment variable that's conventionally used to indicate this.
Allowing colour names to be prefixed with
dark
orbright
to choose a specific variant might be useful. Adding a config option forselectedLineFgColor
might work, too, as I could just set that to black.OTOH, I'm using iTerm2 and my
$TERM
isxterm-256color
, so support for the full range of 256 colours would be ideal :)The text was updated successfully, but these errors were encountered: