Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Move scripts to the head tag #1056

Open
dfsmania opened this issue Feb 7, 2022 · 1 comment
Open

[FEATURE] Move scripts to the head tag #1056

dfsmania opened this issue Feb 7, 2022 · 1 comment
Labels
enhancement Improvement related to this package

Comments

@dfsmania
Copy link
Collaborator

dfsmania commented Feb 7, 2022

Is your request related to a problem? Please describe.

Not a problem, just an improvement...

Describe the solution you'd like

This Stackoverflow post states next:

The current state-of-the-art is to put scripts in the <head> tag and use the async or defer attributes. This allows your scripts to be downloaded ASAP without blocking your browser.

Currently, all scripts are added to the end of the body tag. However, I have been testing moving they to the head tag on some projects and I get less flicker effects when loading pages with multiple plugins.

Describe alternatives you've considered

No other alternatives, just move scripts to the head tag.

Additional context

@REJack as a maintainer of the underlying AdminLTE package, do you think it is safe to move scripts to the head tag?
@dfsmania dfsmania added the enhancement Improvement related to this package label Feb 7, 2022
@REJack
Copy link
Contributor

REJack commented Feb 7, 2022 •
edited
Loading

I personally used often the AdminLTE scripts in head, I'm not a real friend of "end of body scripts". I will test it with some examples and give you a feedback tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement related to this package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@REJack @dfsmania