-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add more options to make output log a bit narrower #164
Comments
Hi thanks for opening this. I'm wondering whether this is something that should be done on the library side or the user side of things. In one of my other libraries, libassert, which uses cpptrace I do a bunch of trace processing to make things look nice (like shortening file paths, folding recursive frames etc, and cleaning up type names in the signatures). I always envisioned this as being how the library would be used; cpptrace does all the "hard work" of generating the trace and the user figures out what to do with it. That being said, I can see how it might be useful to provide some helpful trace cleaning utilities that are generally useful. I'm not immediately sure how best to go about doing this and where to draw the line between generally useful and more project-specific. I'd be interested in your thoughts |
I understand and appreciate the work that this library does, but I feel like a bit of customizations or at least some helpers would be a nice addition. I thought about modify the frames by myself, for (auto it = trace.frames.begin(); it != trace.frames.end(); ++it)
{
auto frame = *it;
if (ShouldBeSkipped(frame))
{
it = trace.frames.erase(it);
continue;
}
frame.filename = MakeNiceFilename(frame.filename);
frame.symbol = MakeNiceSymbol(frame.symbol);
} but then I have to parse the filename and symbol by myself. It would be much easier if the symbol would not be a struct cpptrace::function_symbol {
std::string declaration_owner; // namespace / class path
std::string name;
std::vector<cpptrace::function_parameter> parameters;
std::string to_string() const;
}
struct cpptrace::function_parameter {
std::string type_declaration_owner; // namespace / class path
std::string type_name;
// std::string parameter_name; // impossible to get?
std::string to_string() const;
} Edit: it appears that C++ demangled type names are bit more complicated as the above example <.< |
Thanks for the thoughtful response. I'm inclined to agree cpptrace should do much more on the formatting side of things. I was just running into a use where it would have been really convenient to be able to turn off the I think some sort of
would make sense. Additionally:
Path stuff too makes a lot of sense, though it adds a fair bit of complication on the library side of things. I think stack traces typically have absolute paths, though this isn't a guarantee. Everything is at the mercy of what the compiler decided to output. Handling symbolic links would probably be out of the question, paths in a trace aren't guaranteed to exist. I think trying to add some known base directories would make sense. Possibly the out of source exclusion stuff you mentioned as well, though that might be a little trickier. On my other library, libassert, I do some path disambiguation stuff. E.g. Regarding parsing of the symbol, unfortunately cpptrace usually gets the symbol name as a string so that's just carried through instead of doing any parsing and whatnot :) |
I would really liked it if those features were implemented:
So it does not print
D:\Programming\GitHub\Project\src\stuff\abc\main.c
But rather
src\stuff\abc\main.c
Maybe add a
struct
of all those settings to theprint()
method.Depending on how fancy those settings should be definable you can do something like this
The text was updated successfully, but these errors were encountered: