[JENKINS-41591] Fix pipeline support using TransientActionFactory #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimklimov
reviewed
Jan 18, 2019
|
I'm a user of this plugin (thanks, it's been really helpful!) and would love to see this update landed. Sorry I can't add more than my verbal support here. |
Dohbedoh
force-pushed
the
bugfix/JENKINS-41591
branch
from
828fd8c to
2c0da93
Compare
|
Rebased to master. |
|
I'm fine with this. I'll take en extra look this evening, and we'll see if can get it merged. |
|
Hmm.. Can you make the old action invisible (e.g. nulling the url/name/image) and allow the transient action factory to produce a superclass of the RebuildAction (TransientRebuildAction or similar) and allow that one to be visible instead? This way you could ensure only one action is visible, but don't have to write the boring migration stuff (or resave all the builds). |
|
Ping @Dohbedoh |
GLundh
force-pushed
the
master
branch
2 times, most recently
from
370af40 to
316c049
Compare
6 tasks
|
@GLundh Added a transient field to control this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reviewbybees
Fix pipeline support, using a
TransientActionFactory<Job>and aTransientActionFactory<Run>.Note: Existing builds may have a duplicate "Build" link in the UI because of the non transient action added by previous version of the plugin. We could add a "migration" method although this will be fixed over time once new builds are being scheduled and old build discarded...