-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change icon colour for disabled pipelines to be more visible #552
base: master
Are you sure you want to change the base?
Change icon colour for disabled pipelines to be more visible #552
Conversation
@@ -342,6 +342,11 @@ | |||
background-color: #494D4E !important; | |||
color: #9C9E9E !important; | |||
} | |||
|
|||
.icon-disabled .svg-icon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts @janfaracik ?
I think there's probably a better fix somewhere, the theme tries to just set colors and doesn't have any other CSS rules (apart from the theme above for codemirror)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that this was in the codemirror theme section - it was just the closest looking bit to css that I understood. Happy to move it elsewhere if needed.
It was hard to test the exact change as chrome developer tools fails to load any of the .scss
files, but I arrived at this by editing theme-dark/theme.css
which looks to be generated from this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that is the right file.
The right fix is likely in https://github.com/jenkinsci/jenkins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow, I think the theme-dark/theme.css
file is derived from this file and it doesn't seem to exist in the core. Which makes sense as the core doesn't have any concept of a dark theme?
The core contains _icons.scss
which sets the normal colours for the icons, but again has no concept of a dark theme: https://github.com/jenkinsci/jenkins/blob/0f0b023b0f96d795160544d2e56a4add7244c72e/src/main/scss/components/_icons.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably be changed to be like the unstable one:
https://github.com/jenkinsci/jenkins/blob/0f0b023b0f96d795160544d2e56a4add7244c72e/src/main/scss/components/_icons.scss#L64-L67
So there's a variable for it so we can override the color from black to white without having to change CSS in potentially multiple places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see now, thanks - I'll look at getting that updated to match
Change icon colour for disabled pipelines to be more visible.
Fixes #550
Testing done
Testing done by locally changing css of Jenkins instance
Before:
After:
Submitter checklist