Validate Gradle wrapper #1501
Merged
Validate Gradle wrapper #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Brandes <[email protected]>
timja
reviewed
Mar 10, 2024
| on: [pull_request, push] | ||
| jobs: | ||
| build_pr: | ||
| if: github.repository_owner == 'jenkinsci' |
There was a problem hiding this comment.
Does this work on forks with this if?
There was a problem hiding this comment.
Yes: https://github.com/jenkinsci/acceptance-test-harness/actions/workflows/verify-gradle-wrapper.yaml
The if-clause context refers to the owner of the repository where the workflow is running, not where the PR is coming from.
The job would only be skipped if you file a PR on your fork towards your fork.
jtnord
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed 865cecc and in case someone bumps the wrapper in the future, if needed, the action added validates whether the .jar is legit or not.