Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add vpc outputs #189

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions modules/cluster/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ output "cluster_oidc_issuer_url" {
value = local.oidc_provider_url
}

// ----------------------------------------------------------------------------
// VPC Outputs
// ----------------------------------------------------------------------------
output "vpc" {
description = "All outputs from the VPC module"
value = module.vpc
Copy link
Member

@ankitm123 ankitm123 Nov 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/master/outputs.tf -> This is the list of output that you can use from. So if you just want the id, module.vpc.vpc_id

I think that's why the apply breaks (don't have access to cloudbees servers).

}

// ----------------------------------------------------------------------------
// Long Term Storage S3 Buckets (Logs, Reports, Repository)
// ----------------------------------------------------------------------------
Expand Down
10 changes: 9 additions & 1 deletion outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ output "lts_repository_bucket" {
description = "The bucket that will serve as artifacts repository"
}

// ----------------------------------------------------------------------------
// VPC Outputs
// ----------------------------------------------------------------------------
output "vpc" {
value = module.cluster.vpc
description = "The VPC creation outputs"
}

// ----------------------------------------------------------------------------
// Cluster Name
// ----------------------------------------------------------------------------
Expand Down Expand Up @@ -114,4 +122,4 @@ this command is already executed as part of the apply, you may have to provide t
profile as environment variables "
EOT
value = "aws eks update-kubeconfig --name ${var.cluster_name}"
}
}